Fix winecmd when Wine path contains spaces
#2108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `winecmd` verb when path to Wine contains a space. The arguments for `winetricks_shell` were passed as-is in a space-separated string, meaning a single argument with a space in it (eg. the Wine path) would break the entire command. Fix this by single quoting each argument and concatenating them together. This is a bit tricky in POSIX sh without `printf %q`, but seems to work fine with the code suggested by ShellCheck for SC3050.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2037. While that PR fixed
-eparameter for some terminals such asxterm, the single string passed as argument was not escaped properly, causingwinecmdto fail ifWINEcontained a space.Fix this by single quoting each argument and concatenating them together. This is a bit tricky in POSIX sh without
printf %q, but seems to work fine with the code suggested by ShellCheck for SC3050.I went ahead and tested the fix with every terminal except for
Terminal, and it should work properly in all cases now.