fix async pathfinding tick rate#785
Open
hayanesuru wants to merge 1 commit into
Open
Conversation
Dreeam-qwq
approved these changes
Jun 23, 2026
noramibu
suggested changes
Jun 30, 2026
noramibu
left a comment
Contributor
There was a problem hiding this comment.
IMHO this looks risky because it can make async pathfinding run on the main server thread again
From what I understand, old logic only used pending path when the async worker had already finished it, but new logic tries to finish the pending path immediately. If the async worker has not finished yet, main thread may end up waiting for it or doing the path calculation itself and under load it may cause TPS/MSPT spikes, especially with villagers searching for beds or job sites
I believe a safer flow would be: if the pending path is ready, use it; if it is not ready yet, keep it pending and try again later ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cache paper sensor & behavior tick rate
remove no effect
CompletableFuture#orTimeoutreplace
NearestBedSensortick rate