Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Number of jobs should not be set in Makefile #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Topkek-190
Copy link

The value of N in -jN depends on many factors and the decision should be ultimately left up to the user

j16 is an awful lot of jobs and usually results in termination of the compiler.
The number of jobs used by make can be set using the command line argument -jN
to make, where N is the number of jobs
@Topkek-190
Copy link
Author

cc: @rouben

@rouben
Copy link
Collaborator

rouben commented Oct 14, 2021

The issue with this PR is that it will be difficult to maintain once a new release is available upstream. Remember, this repo is based on the contents of 7Zip/ZIP archives released upstream by the original author, who maintains their own private SubVersion repo for development.

Any ideas on how we can prevent this change from getting squashed with future releases?

@Topkek-190
Copy link
Author

Topkek-190 commented Oct 15, 2021

Manually merging the Makefile, maybe?
Or maybe a patch could be sent to the author(probably the only viable approach).
Has any progress been made on the licensing issue?

@Topkek-190
Copy link
Author

Topkek-190 commented Mar 25, 2022

@rouben I think, since the software hasn't been updated since 2020, it's probably better to make a tag for the current HEAD and then apply some fixes so that if a new version is released on the MDL website then the repo can be updated easily by making a branch at the original head, i.e. the tag.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants