Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update English.pot #2079

Closed
wants to merge 1 commit into from
Closed

Update English.pot #2079

wants to merge 1 commit into from

Conversation

Need74
Copy link
Contributor

@Need74 Need74 commented Oct 29, 2023

Hi
to make possible the translation into French (or another language) of the "print preview" window, I tried without success to add the few lines of the missing words in my french.po file but this had no effect. This did not surprise me too much since these words are absent from the English base english.pot but it may not be enough to declare this translation if the binary is not up to date for this. It is possible that my proposal is wrong and in this case I apologize but it would be nice to be able to translate the print preview page into all languages. Kind regards, Denis

PS I haven't found anywhere a possible configuration for my WinMerge to detect updates and I am therefore obliged to visit GitHub from time to time to check for new features.

Hi
to make possible the translation into French (or another language) of the "print preview" window, I tried without success to add the few lines of the missing words in my french.po file but this had no effect.
This did not surprise me too much since these words are absent from the English base english.pot but it may not be enough to declare this translation if the binary is not up to date for this.
It is possible that my proposal is wrong and in this case I apologize but it would be nice to be able to translate the print preview page into all languages.
Kind regards, Denis

PS I haven't found anywhere a possible configuration for my WinMerge to detect updates and I am therefore obliged to visit GitHub from time to time to check for new features.
@sdottaka
Copy link
Member

Print Preview is displayed by the MFC library, so it seems that some effort is needed to make it translatable.
Also, English.pot is a file that is automatically generated from Merge.rc, so it is not appropriate to modify this file.

@Need74
Copy link
Contributor Author

Need74 commented Oct 31, 2023

Hi
thank you for your response and I note english.pot is not an editable file.
However, I have found errors when translating the software into French and sometimes my translation problem is linked to the fact that the english.pot model does not allow the function of a command menu to be intelligently translated or that of a control button label.
On this subject I discovered an interpretation error between Left, Right, Midle, and 'on the left' 'on the right' 'from or towards the middle' which led to keyboard shortcuts being included in the menus or tooltips which are not correct. In fact, these shortcuts depend on the panel where the insertion point is located in the case of use in 3 panel mode.
Thank you for telling me how I can make my observation and also my proposal for correction, knowing that this is only a problem with the interface but not functionality.
Sincerely
Dennis

@sdottaka
Copy link
Member

First, I cannot apply this Pull Request, so I will temporarily close it.
Regarding the issue of the untranslated "Print Preview" buttons, I have created a new issue #2083.

On this subject, I discovered an interpretation error between "Left," "Right," "Middle," and "on the left," "on the right," "from or towards the middle," which led to keyboard shortcuts being included in the menus or tooltips that are not correct. In fact, these shortcuts depend on the panel where the insertion point is located when used in the 3-panel mode.

Regarding this matter, it is a separate issue from Print Preview, so could you create a new issue and provide specific details about your expectations and the actual results?
Additionally, it might be challenging to change menus and tooltips based on the selected pane.

@sdottaka sdottaka closed this Oct 31, 2023
sdottaka added a commit that referenced this pull request Nov 6, 2023
@sdottaka
Copy link
Member

Commits a0abf31 and d021044 made print preview buttons translatable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants