Skip to content

SER- Properly handle arrow up key in search suggestion navigation #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SER- Properly handle arrow up key in search suggestion navigation #193

wants to merge 1 commit into from

Conversation

mmeller-wikia
Copy link

@mmeller-wikia mmeller-wikia commented Dec 2, 2020 •
edited
Loading

When selecting suggestion with keys on discussions up arrow doesn't work

Reference: https://stackoverflow.com/a/5597114

@mmeller-wikia mmeller-wikia requested a review from vforge as a code owner December 2, 2020 08:58
kasperekt
kasperekt requested changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@kasperekt kasperekt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would even go further. keyCode property is deprecated. Let's switch to key. It's definitely more readable.

Ref:

@mmeller-wikia mmeller-wikia force-pushed the SER-seach-suggestion-key-navigation branch from 16a1531 to 6ec94d7 Compare December 2, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperekt kasperekt kasperekt approved these changes

@vforge vforge Awaiting requested review from vforge vforge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmeller-wikia @kasperekt