Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COTECH-506] Default player set for 100% of the traffic. #183

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[COTECH-506] Default player set for 100% of the traffic. #183

wants to merge 4 commits into from

Conversation

dzawada
Copy link

@dzawada dzawada commented Aug 23, 2023

No description provided.

@dzawada dzawada requested a review from p-forfa August 23, 2023 14:12
p-forfa
p-forfa approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@p-forfa p-forfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I would just make sure to add JWPlayer's float on scroll for the DesktopArticleVideoPlayer's jwplayer id once this is removed, and remove the custom coded float on scroll behavior from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latata latata latata left review comments

@andrzejkupczyk andrzejkupczyk andrzejkupczyk approved these changes

@p-forfa p-forfa p-forfa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dzawada @latata @andrzejkupczyk @p-forfa