-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Drainage Area Analyze View #3559
Open
rajadain
wants to merge
8
commits into
develop
Choose a base branch
from
tt/drainage-area-analyze-view
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Aug 2, 2022
-
Wrap Drainage Area Analyze results in
survey
In order to be compliant with the API exposed by all other /analyze/ endpoints, the final results should be wrapped in `survey`. This allows easy use on the front-end.
Configuration menu - View commit details
-
Copy full SHA for b3c7190 - Browse repository at this point
Copy the full SHA b3c7190View commit details -
Refactor: Move Download CSV button into TableView
Previously this was present in the parent ResultView. Now, as we prepare to reuse the TableView elsewhere, we move the Download CSV button to be within it so that it is present in the Drainage Area Analyze view where it will next be used.
Configuration menu - View commit details
-
Copy full SHA for e30d4ea - Browse repository at this point
Copy the full SHA e30d4eaView commit details -
So they can be reused in Drainage Area Analysis
Configuration menu - View commit details
-
Copy full SHA for 59c7a17 - Browse repository at this point
Copy the full SHA 59c7a17View commit details -
Wire through drainage area variable
When the area of interest is a drainage area, we now set this new areaOfInterestDrainageArea attribute to true. It is false by default, and reset to false when the AoI is cleared.
Configuration menu - View commit details
-
Copy full SHA for a801ca8 - Browse repository at this point
Copy the full SHA a801ca8View commit details -
Implement Drainage Area Analyze View
When the area of interest is a Drainage Area, we show an additional Analyze Tab, which shoes contents of the GWLF-E Runoff and Water Quality views. The Drainage Area Result View is made quite akin to the Analyze Result View, but had to be seprate because of its custom CSV Export handling.
Configuration menu - View commit details
-
Copy full SHA for ca3e53e - Browse repository at this point
Copy the full SHA ca3e53eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3068c1d - Browse repository at this point
Copy the full SHA 3068c1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d224b4 - Browse repository at this point
Copy the full SHA 5d224b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0eda2dd - Browse repository at this point
Copy the full SHA 0eda2ddView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.