Display alert when RWD does not yield a valid watershed #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,11 +41,22 @@ function actOnLayer(datum) { | |||
| } | |||
| } | |||
|
|
|||
| // Takes a GeoJSON shape, or if a key is specified, a dict | |||
| // with a GeoJSON object found at shape[shapeKey] | |||
| function validateShape(shape, shapeKey) { | |||
There was a problem hiding this comment.
Removing this will actually fix a newly reported bug #1166
|
+1 |
There are certain conditions where the RWD job completes successfully, but does not yield a valid watershed. Without this alert, there is no indication that the job completed or not. The reason this is a plain alert box instead of something nicer, is because we intend to address the cause behind the null watersheds soon. Ref: WikiWatershed/rapid-watershed-delineation#27 Fixes WikiWatershed#1166
kdeloach
force-pushed
the
feature/null-watershed
branch
from
38490e8
to
48151a6
Compare
|
Cool, I added more details in the commit description too. |
kdeloach
added a commit
that referenced
this pull request
Mar 10, 2016
Display alert when RWD does not yield a valid watershed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain conditions where the RWD job completes successfully,
but does not yield a valid watershed. Without this alert, there is no
indication that the job completed or not.
The reason this is a plain alert box instead of something nicer, is
because we intend to address the cause behind the null watersheds soon.
Ref: WikiWatershed/rapid-watershed-delineation#27
Fixes #1166