Improvements to maintenance script and fix job

CHANGELOG.md

@@ -1,5 +1,11 @@
 ## ChangeLog for RottenLinks
 
+### 2.0.1 (16-12-2023)
+* Add `requireExtension` to updateExternalLinks.
+* Remove unnecessary object cache from being added in updateExternalLinks.
+* Prevent duplicate entries from being added to rottenlinks table in updateExternalLinks.
+* Fix table name used in RottenLinksJob.
+
 ### 2.0.0 (15-12-2023)
 * Redesign RottenLinks to not depend on a maintenance script
 * Changes how we count page usage on RottenLinks special page. We directly gather this from externallinks table rather then storing it separately.

extension.json

@@ -1,6 +1,6 @@
 {
 	"name": "RottenLinks",
-	"version": "2.0.0",
+	"version": "2.0.1",
 	"author": [
 		"John Lewis",
 		"Paladox",

includes/RottenLinksJob.php

@@ -62,13 +62,13 @@ public function run() {
 
 				$rottenLinksCount = $dbw->newSelectQueryBuilder()
 					->select( 'rl_externallink' )
-					->from( 'externallinks' )
+					->from( 'rottenlinks' )
 					->where( [ 'rl_externallink' => $url ] )
 					->caller( __METHOD__ )
 					->fetchRowCount();
 
 				if ( $rottenLinksCount > 0 ) {
-					// Don't create duplicate entires
+					// Don't create duplicate entries
 					continue;
 				}
 

maintenance/updateExternalLinks.php

@@ -4,7 +4,6 @@
 
 use Maintenance;
 use MediaWiki\MediaWikiServices;
-use ObjectCache;
 use WikiForge\RottenLinks\RottenLinks;
 
 $IP = getenv( 'MW_INSTALL_PATH' );
@@ -19,6 +18,8 @@ public function __construct() {
 		parent::__construct();
 
 		$this->addDescription( 'Updates rottenlinks database table based on externallinks table.' );
+
+		$this->requireExtension( 'RottenLinks' );
 	}
 
 	public function execute() {
@@ -72,6 +73,18 @@ public function execute() {
 				continue;
 			}
 
+			$rottenLinksCount = $dbw->newSelectQueryBuilder()
+				->select( 'rl_externallink' )
+				->from( 'rottenlinks' )
+				->where( [ 'rl_externallink' => $url ] )
+				->caller( __METHOD__ )
+				->fetchRowCount();
+
+			if ( $rottenLinksCount > 0 ) {
+				// Don't create duplicate entries
+				continue;
+			}
+
 			$resp = RottenLinks::getResponse( $url );
 			$pagecount = count( $pages );
 
@@ -88,10 +101,6 @@ public function execute() {
 
 		$time = time() - $time;
 
-		$cache = ObjectCache::getLocalClusterInstance();
-		$cache->set( $cache->makeKey( 'RottenLinks', 'lastRun' ), $dbw->timestamp() );
-		$cache->set( $cache->makeKey( 'RottenLinks', 'runTime' ), $time );
-
 		$this->output( "Script took {$time} seconds.\n" );
 	}