fix: eslint errors in admin quick actions #6218
Conversation
| @@ -563,6 +563,7 @@ en: | |||
| Your course has been cloned, including the elements of the timeline | |||
| (weeks and blocks). Be sure to add the dates, which are not carried over. | |||
| Has anything else about your course changed? Feel free to update it now. | |||
| closed_on: This course was closed on | |||
There was a problem hiding this comment.
We should only use complete messages in the locale files, rather than fragments like this that interact grammatically with other content before or after. (These are "lego" messages which need to be assembled from pieces, and they cause problems for translators.)
There was a problem hiding this comment.
But if we won't fix this, we would get into this:
There was a problem hiding this comment.
We have a lot of these extant in the codebase. Fixing them is good when it's convenient and makes sense, but I think we need to find a pattern for disabling the linting rule when using i18n is not needed... which is true for any feature that is admin-facing and is only used in Wiki Education mode (like this one).
There was a problem hiding this comment.
Hmm...need to find an alternative
What this PR does
It fixes the ES Lint errors which were seen after merging #6213