Fix: Prevents 414 request-uri too long
for import_articles_by_title
by using a POST request
#6212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes 414 request-uri too long for import_articles_by_title by using a POST request instead of a GET request:
meta
method in wiki_api to prevent:The former code
site_info = WikiApi.new(self).query(meta: :siteinfo)
inwiki.rb
'sensure_wiki_exists
method worked because thequery
method is a general entry point for all API requests and themediawiki
gem automatically processesmeta
requests since it is a valid method. My change to wiki_api's query method however bypasses the gem's automatic routing ofmeta: :siteinfo
causing the error.The solution was implementing a
meta
method in theWikiApi
class that directly calls themeta
method from themediawiki-api
gem.414 request-uri too long no longer occurs
and a new vcr-cassettesome_article_titles.yml
Screenshots
Before:

After:

