Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored add_available_articles.jsx from class to functional component #5574

Conversation

omChauhanDev
Copy link
Contributor

What this PR does

Refactored from class to functional component.

Before

Before:
Screencast from 2023-12-31 11-01-47.webm

After:
After.webm

@ragesoss
Copy link
Member

ragesoss commented Jan 8, 2024

A quick look at the code looks good, but I'd like to get #5568 sorted out before merging this; I can see it happens in both of your videos.

@ragesoss
Copy link
Member

Okay, I believe that error in your videos was the Redis thing in your environment, which I think I posted about elsewhere... so, this is good to go.

@ragesoss ragesoss merged commit 38fca01 into WikiEducationFoundation:master Jan 17, 2024
1 check passed
Copy link

sentry-io bot commented Jan 18, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of null (reading 'map') AddAvailableArticles.submit(app/assets/javascri... View Issue

Did you find this useful? React with a 👍 or 👎

@omChauhanDev omChauhanDev deleted the RefactoringReactClassComponentsStream3 branch January 29, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants