Refactored article_finder.jsx to Functional Component #5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ragesoss Kindly guide me fixing this error due to which this CI / build test is failing. |
|
Hmmm... it's the article finder spec that is failing, so you should check whether that spec passes locally for you. I'll re-run CI just in case it was simply a flaky test unrelated to your change. |
|
@ragesoss I tried running yarn test locally and all the 36 test suites of 204 tests passed successfully. All.Test.Passed.webm |
|
@om-chauhan1 |
omChauhanDev
force-pushed
the
RefactoringClassComponentsStream2
branch
from
c24ec66 to
799d03b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored Article Finder from class component to functional component.
For Article Finder
Before:
Before.webm
After:
After.webm