-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal to show username/email advice before sending users to Wikipedia #5564
Modal to show username/email advice before sending users to Wikipedia #5564
Conversation
I tried running the CI with Also @ragesoss can I gen an invite for the slack channel? |
…ttps://github.com/ujjwalpathaak/WikiEduDashboard into fix_3295/Adding_advice_page_before_login_redirect
Currently the model is looking like this - |
What suggestions should i put in? |
Here's a quick draft:
|
…vice_page_before_login_redirect
@ragesoss this PR is ready for review. Also can I get an invite for Slack? |
Yes, please let me know your email address (or email me at sage at wikiedu.org) |
email -> [email protected] The examples failing doesn't seem to be related to my changes - |
Screencast.from.04-01-24.03.28.48.AM.IST.webmWikiEd Config - |
New videos look perfect! |
import NewAccountButton from './new_account_button'; | ||
import PropTypes from 'prop-types'; | ||
|
||
const AdviceModal = ({ setModalShown, course, passcode, user }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using a more specific name like 'UsernameAdviceModal'.
One thing I didn't notice until testing it locally is a UI bug from when you converted |
Refs #3295
What this PR does
I have tried using two different approach for both jsx component and server componet.
This adds an intermediate state between the process of redirecting users to create a new account.
If this looks good I can work further on this issue as it would need more changes in terms of the tests and overall functionality.
Sample
Screencast.from.26-12-23.04.51.59.PM.IST.webm
Screencast.from.25-12-23.10.06.39.PM.IST.webm