Skip to content

Commit

Permalink
Mark flaky spec as pending
Browse files Browse the repository at this point in the history
This spec is very fragile, as it could potentially break for both intermittent failures (like rate limiting based on the IP range of the CI system) as well as from changes to any specific supported language (ie, if revision 1234 gets deleted on that wiki).

At some point, we should either refactor this significantly for easier debugging, or find a better strategy for testing that we can successfully get LiftWing articlequality data for all the projects we think we can. For today, I just want the tests to be green.
  • Loading branch information
ragesoss committed Jan 2, 2024
1 parent 01df707 commit 5b76c58
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions spec/lib/importers/revision_score_importer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@
end

it 'imports data and calcuates an article completeness score for available wikis' do
pending 'This sometimes fails, likely because of rate limiting. We should look into it.'

VCR.use_cassette 'revision_scores/multiwiki' do
described_class.update_revision_scores_for_all_wikis

Expand All @@ -215,6 +217,8 @@

expect(wikidata.revisions.first.features).not_to be_empty
end

pass_pending_spec
end
end

Expand Down

0 comments on commit 5b76c58

Please sign in to comment.