Skip to content

Commit

Permalink
added some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jlloyd-widen committed Jan 12, 2024
1 parent aebf20f commit 6288e87
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tap_mysql/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,9 @@ def discover_catalog_entries(self) -> list[dict]:
# inject the table_schema into the list of columns
custom_rec_keys = list(custom_rec.keys()) + ["mysql_schema"]

# note that all columns are forced to be strings to avoid
# the complexity of inferring their data types. Warning this could
# cause issues in the loss of precision of data
custom_columns = []
for col in custom_rec_keys:
custom_columns.append(
Expand Down Expand Up @@ -375,6 +378,7 @@ def post_process(
Returns:
The resulting record dict, or `None` if the record should be excluded.
"""
# force all values to be strings for simplicity
new_row = {k: str(v) for k, v in row.items()}
# inject the mysql_schema into the record
new_row["mysql_schema"] = self.mysql_schema
Expand Down

0 comments on commit 6288e87

Please sign in to comment.