really disable risky functions #19
Conversation
remicollet
changed the title
realpath_turbo.c
Outdated
| @@ -118,6 +113,12 @@ PHP_RINIT_FUNCTION(realpath_turbo) | |||
|
|
|||
| PHP_MINIT_FUNCTION(realpath_turbo) | |||
| { | |||
| #if PHP_MAJOR_VERSION < 8 | |||
| zend_disable_function("link", sizeof("link")-1 TSRMLS_CC); | |||
There was a problem hiding this comment.
I am wondering about this change. Looks like we would now always disable these functions...
There was a problem hiding this comment.
In short, function from configuration are disabled at PHP startup, additional ones by the plugin during MINIT.
The ini stuff is only useful if some user check configuration, for consistency
There was a problem hiding this comment.
Sorry, I don't read enough your question...
Looks like we would now always disable these functions...
Indeed... grr
There was a problem hiding this comment.
Should be ok now, + new test
|
@Whissi FYI, this package was requested by user of my repository, the reason why I look a bit on it See https://blog.remirepo.net/pages/PECL-extensions-RPM-status |
| @@ -2,9 +2,11 @@ | |||
| #include "realpath_turbo_private.h" | |||
|
|
|||
| static zend_function_entry realpath_turbo_functions[] = { | |||
| {NULL, NULL, NULL} | |||
| PHP_FE_END | |||
Ready for review
Tested with PHP 5.6, 7.0, 7.1, 7.2, 7.3, 7.4 and 8.0.0beta4