Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct my last commit (I made some mistakes) #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

YiraSan
Copy link
Contributor

@YiraSan YiraSan commented Jul 12, 2024

Ubisoft Connect only needs windows 7 :')

Ubisoft Connect only needs windows 7 :')
@@ -4,9 +4,9 @@
{{#template ../templates/rating.md status=Silver installs=Yes opens=Yes}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If "practically nothing is rendered properly" , I would suggest changing the status to Bronze, as that sounds to me like it "severely limits" playability.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YiraSan I agree with @hahayupgit. Can you change it and clarify the NOTE section below?

@@ -4,9 +4,9 @@
{{#template ../templates/rating.md status=Silver installs=Yes opens=Yes}}

> [!NOTE]
> On MacOS Sonoma the games launch and finishing a map is technically possible, but pratically nothing is rendered (only trees ?)
> On MacOS Sonoma (before GPTK 2) the game launch and finishing a map is technically possible, but pratically nothing is rendered properly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify on what you mean about "MacOS Sonoma (before GPTK 2)"?

Are you saying that you've:
A) only tested the game on MacOS Sonoma, and before the GPTK 2.0 update?
or B) tested the game on both MacOS Sonoma and MacOS Sequoia, both before and after the GPTK 2.0 update, and this issue only occurs with Sonoma before the 2.0 update?

If its A, you can remove this clarification about MacOS Sonoma, and I request that you test the game with GPTK 2.0, and if it's B, can you add a clarification about how the game runs with Sequoia and GPTK 2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the game launch before GPTK 2.0 but practically nothing renders (some trees), but I managed to end multiple races because I know them, so the game logic works, but there's no render, and with GPTK 2.0 everything works as intended.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh i see what you're saying, i'm gonna test it myself to see what you're saying then this can get merged, though i'll probably remove the note about GPTK 2 because we don't typically include any statements that affect previous versions of whisky

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hahayupgit I think you can write this idea down - about skiping info about previous Whisky versions in docs. I agree with that.

@hahayupgit hahayupgit added the docs addition Improvements or additions to documentation label Aug 23, 2024
@hahayupgit hahayupgit added the question/awaiting changes Further information is requested label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs addition Improvements or additions to documentation question/awaiting changes Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants