Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale duplicate alert on glossary #13511

Open
2 tasks done
nijel opened this issue Jan 15, 2025 · 0 comments
Open
2 tasks done

Stale duplicate alert on glossary #13511

nijel opened this issue Jan 15, 2025 · 0 comments
Labels
bug Something is broken.
Milestone

Comments

@nijel
Copy link
Member

nijel commented Jan 15, 2025

Describe the issue

There is duplicate string alert on glossary component without a matching unit after such string is removed in Weblate.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Create duplicate entry in a glossary component, in past, this might have been caused by Some glossary terms are saved twice to TBX causing translations to disappear #9701, but has to be done manually on the repository now.
  2. Make Weblate load these strings.
  3. Observe there is DuplicateString alert triggered.
  4. Remove the problematic string in Weblate.
  5. The alert is still there, it just no longer links to a string.

Expected behavior

The alert should disappear when problematic string is removed.

Screenshots

Screenshot 2025-01-14 at 03 42 44

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

The DuplicateString alert is triggered only upon parsing the files, so it is never cleared on normal operations on a glossary component without a remote repository (adding/removing strings does not trigger that).

Therefore, all import only errors should be revisited if they can't disappear in other situations. In case there is the only one affected, we might hook into unit removal and remove the unit from alert when it is being removed. The alert itself can be removed once there are no units left. Some more complex solution might be needed when there are more such alerts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

1 participant