Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8a8c1ca4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| or not ANUBIS_PATH_PATTERN.fullmatch(parsed.path) | ||
| or parsed.query | ||
| or parsed.fragment | ||
| or (port is not None and not 1 <= port <= 65535) |
There was a problem hiding this comment.
When WEBLATE_ANUBIS_URL is http://anubis: (or http://anubis:/path), urlsplit().port returns None, making this check indistinguishable from a URL with no port. The validator therefore succeeds and emits proxy_pass http://anubis:;, which nginx rejects because the colon introduces an empty port, causing container startup to fail instead of reporting the invalid environment value here.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
But it will be still clear where the error is. Let's rather keep the logic simple than cover all the corner cases.
1 participant
No description provided.