Fixed: inspecting document.title deleted it as a side-effect (when cached) #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-classen
added a commit
to ghostery/ghostery-extension
that referenced
this pull request
Mar 22, 2024
Switching to linkedom/cached introduced a regression. See WebReflection/linkedom#266
smalluban
pushed a commit
to ghostery/ghostery-extension
that referenced
this pull request
Mar 25, 2024
Switching to linkedom/cached introduced a regression. See WebReflection/linkedom#266
esm/html/document.js
Outdated
| @@ -77,13 +77,13 @@ export class HTMLDocument extends Document { | |||
| */ | |||
| get title() { | |||
| const {head} = this; | |||
| let title = head.getElementsByTagName('title').shift(); | |||
| let title = head.getElementsByTagName('title')[0]; | |||
There was a problem hiding this comment.
I think these days I would go for .at(0) instead ... so this could be:
get title() {
const {head} = this;
return head.getElementsByTagName('title').at(0)?.textContent || '';
}
esm/html/document.js
Outdated
| @@ -77,8 +77,7 @@ export class HTMLDocument extends Document { | |||
| */ | |||
| get title() { | |||
| const {head} = this; | |||
| let title = head.getElementsByTagName('title')[0]; | |||
| return title ? title.textContent : ''; | |||
| return head.getElementsByTagName('title')[0]?.textContent || ''; | |||
There was a problem hiding this comment.
.at(0) ... not [0] ... [0] bails out performance if no title exists, .at(0) doesn't suffer this issue.
philipp-classen
force-pushed
the
fix_title_getter_in_cached_mode
branch
from
ec40b5d
to
ad2ae02
Compare
|
Thanks! It's up and running. If you had an issue please be sure that gets closed too 👋 |
philipp-classen
added a commit
to whotracksme/webextension-packages
that referenced
this pull request
Mar 25, 2024
philipp-classen
added a commit
to whotracksme/webextension-packages
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal reproducible example with linkedom 0.16.10: