Implementation of customElements.getName()
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mash-graz
changed the title
customElements.getName()
| * @param {Function} Class **Class** of custom element | ||
| * @returns {string?} found tag name or null | ||
| */ | ||
| getName(Class){ |
There was a problem hiding this comment.
some indentation issue here ... one less space for getName and the rest of the code, otherwise this looks good to me.
There was a problem hiding this comment.
Should be fixed now!
Thanks for your fast response.
| @@ -195,7 +195,7 @@ export class CustomElementRegistry { | |||
| * @param {Function} Class **Class** of custom element | |||
| * @returns {string?} found tag name or null | |||
| */ | |||
| getName(Class){ | |||
| getName(Class) { | |||
There was a problem hiding this comment.
this is also good but I wasn't clear ... see indentation compared to get(...)
There was a problem hiding this comment.
O.k. -- I finally got it! :)
Indentation should be fixed now.
| @@ -195,7 +195,7 @@ export class CustomElementRegistry { | |||
| * @param {Function} Class **Class** of custom element | |||
| * @returns {string?} found tag name or null | |||
| */ | |||
| getName(Class){ | |||
| getName(Class) { | |||
There was a problem hiding this comment.
this is also good but I wasn't clear ... see indentation compared to get(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #253