-
Notifications
You must be signed in to change notification settings - Fork 88
Tweak NewsSite test step scenarios #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'm not opposed to this change in general. @flashdesignory what's your take here? |
btw, you can use crossbench to create browser comparison data easily. |
Hi @camillobruni, thanks for your comments. Below are the crossbench results for this PR from 10 runs. We ran the whole benchmark and extracted the scores for NewsSite cases. this PR
main
System and browser version
Basically, NewsSite-Next runs slower while NewsSite-Nuxt runs faster. This difference is related to how each framework handles In NewsSite-Nuxt, the Vue router leverages microtasks for its navigation mechanism, so a forced layout of a new tab does not happen synchronously. However, in NewsSite-Next, |
Hi @camillobruni, Just kindly ping :) Do you have any comments or suggestions on this idea? Thank you! |
Could you try kicking off the try-jobs again? |
3d2f487
to
1411d4a
Compare
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @camillobruni, I just did a rebase and triggered a new round of CI runs. |
This proof of concept illustrates potential tweaks to the test steps for the NewsSite workload. It introduces an extra navigation to a new tab instead of repeatedly toggling the drop-down menu.