Delay the fade-in animation until the fps calculation is done. #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some small devices the animation is causing that the fps calculation does not get the correct number because the animation is too heavy. This change adds some seconds to the start of the initial fade-in animation to make sure it happens when the fps calculation is done. We also delay the next color change animation accordingly.
✅ Deploy Preview for webkit-motionmark-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some small devices the animation is causing that the fps calculation does not get the correct number because the animation is too heavy. This change adds some seconds to the start of the initial fade-in animation to make sure it happens when the fps calculation is done. We also delay the next color change animation accordingly.