Replace prefetch logic (#251) is a 2% regression #262
Merged
+281
−271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A/B testing indicates this change caused a 2% score change in Safari. This seems surprising since this was intended to be a purely harness change. Reverting for now to confirm and to investigate the cause. This also reverts "Add resource loading bar (WebKit#246)" and "Improve Benchmark constructor and instance variables (WebKit#255)" as they blocked a clean revert. For posterity, this is tracked internally as rdar://problem/168103740
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Gonna merge this for now CC @camillobruni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A/B testing indicates this change caused a 2% score change in Safari. This seems surprising since this was intended to be a purely harness change. Reverting for now to confirm and to investigate the cause.
This also reverts "Add resource loading bar (#246)" and "Improve Benchmark constructor and instance variables (#255)" as they blocked a clean revert.
For posterity, this is tracked internally as rdar://problem/168103740