use experimental oracles #1346
use experimental oracles #1346
Conversation
|
|
||
| fun getDisabledOracleCodesList(): List<FaultCategory> { | ||
| if (disabledOracleCodesList == null) { | ||
| val definedCategories = DefinedFaultCategory.values().asList() |
There was a problem hiding this comment.
this is a long if statement, where the else is just a return. to avoid unnecessary nesting (which reduce code readability), the condition should be negated (eg if(disabledOracleCodeList != null)), and return immediately if so
| disabledOracleCodesList = (disabledOracleCodesList!! + experimentalCategories).distinct() | ||
| } | ||
| } | ||
| return disabledOracleCodesList!! |
There was a problem hiding this comment.
so, if user specifies some codes to skip, then the content of useExperimentalOracles is ignored? i don't think that would be correct. I think here a better approach is to change this function, to do not return a list of codes, but a boolean, something like isFaultCodeActive(fault): Boolean, so the logic has to be implemted only once
|
@omursahin thx, but this not what I meant. maybe it is easier if I fix it directly, ie, i ll take over this branch |
2 participants
No description provided.