Stack Trace Oracle #1336
Stack Trace Oracle #1336
Conversation
|
|
||
| val body = result.getBody() | ||
|
|
||
| if(body != null && StackTraceUtils.looksLikeStackTrace(body)){ |
There was a problem hiding this comment.
somehow, this check should be done in the fitness function as well. otherwise, if a test is cloned and its fitness recomputed, we lose the info.
in the fitness function, it could be checked only for 500 and for SECURITY type tests
| copyTarget.evaluatedMainActions().forEach { action -> | ||
| // body | ||
| val result = (action.result as RestCallResult) | ||
| val action = (action.action as RestCallAction) |
There was a problem hiding this comment.
doesn't action here overshadow the action in line 310?
also, shouldn't we just look at the ones with same verb and path from 310 instead of all actions in a test?
| * @param text the log or string to analyze | ||
| * @return true if the text appears to be a stack trace | ||
| */ | ||
| fun looksLikeStackTrace(text: String): Boolean { |
There was a problem hiding this comment.
we need several unit test for this function, with example of real-world response strings (taking from googling) from different languages (at least the ones we use here) and major frameworks.
we need both "positive" and "negative" examples
| actionResults: List<ActionResult>, | ||
| fv: FitnessValue | ||
| ) { | ||
| for(index in individual.seeMainExecutableActions().indices){ |
There was a problem hiding this comment.
shouldn't be a check for config.getDisabledOracleCodesList()?
There was a problem hiding this comment.
I added this check for all oracle types in the AbstractRestFitness.
| */ | ||
| private fun handleStackTraceCheck(){ | ||
|
|
||
| mainloop@ for(action in actionDefinitions){ |
There was a problem hiding this comment.
check for config.getDisabledOracleCodesList() ?
There was a problem hiding this comment.
I am checking it in accessControlBasedOnRESTGuidelines.
|
|
||
| mainloop@ for(action in actionDefinitions){ | ||
|
|
||
| val suspicious = RestIndividualSelectorUtils.findIndividuals( |
There was a problem hiding this comment.
we need a bit of code comments to explain why we need BOTH the check here and in the fitness function.
- here: because we need to make sure 500 from archive are re-executed and added back with SECURITY tag if fault found
- in ff: to avoid losing info if test is re-evaluated
|
@omursahin before merging, i just realized that oracle would be on by default. until we run full experiments on WFD, we cannot have it. |
2 participants
No description provided.