Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #428

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Bugfix #428

merged 3 commits into from
Aug 21, 2024

Conversation

HenryRiley0
Copy link
Contributor

1.fix implicitly type error of LogMessage
2.fix gdb check error, checkCommand success should not warning "Configured debugger ${dbgCommand} not found"

	protected checkCommand(debuggerName: string): boolean {
		try {
			const command = process.platform === 'win32' ? 'where' : 'command -v';
			execSync(`${command} ${debuggerName}`, { stdio: 'ignore' });
			return true;
		} catch (error) {
			return false;
		}
	}

@HenryRiley0
Copy link
Contributor Author

the newest code will fail, please consider merge this pr

@GitMensch
Copy link
Collaborator

I'd like to pull that in, can you please add your notes to the Changelog as well?

@HenryRiley0
Copy link
Contributor Author

I'd like to pull that in, can you please add your notes to the Changelog as well?

ok, i will put a changelog later

@HenryRiley0
Copy link
Contributor Author

HenryRiley0 commented Aug 21, 2024

I'd like to pull that in, can you please add your notes to the Changelog as well?

change log added @GitMensch

@GitMensch GitMensch merged commit 7d61f09 into WebFreak001:master Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants