Skip to content

Bugfix - #428

Merged
GitMensch merged 3 commits into
WebFreak001:masterfrom
HenryRiley0:bugfix
Aug 21, 2024
Merged

Bugfix#428
GitMensch merged 3 commits into
WebFreak001:masterfrom
HenryRiley0:bugfix

Conversation

@HenryRiley0

Copy link
Copy Markdown
Contributor

1.fix implicitly type error of LogMessage
2.fix gdb check error, checkCommand success should not warning "Configured debugger ${dbgCommand} not found"

	protected checkCommand(debuggerName: string): boolean {
		try {
			const command = process.platform === 'win32' ? 'where' : 'command -v';
			execSync(`${command} ${debuggerName}`, { stdio: 'ignore' });
			return true;
		} catch (error) {
			return false;
		}
	}

@HenryRiley0

Copy link
Copy Markdown
Contributor Author

the newest code will fail, please consider merge this pr

@GitMensch

Copy link
Copy Markdown
Collaborator

I'd like to pull that in, can you please add your notes to the Changelog as well?

@HenryRiley0

Copy link
Copy Markdown
Contributor Author

I'd like to pull that in, can you please add your notes to the Changelog as well?

ok, i will put a changelog later

@HenryRiley0

HenryRiley0 commented Aug 21, 2024 •

Copy link
Copy Markdown
Contributor Author

I'd like to pull that in, can you please add your notes to the Changelog as well?

change log added @GitMensch

@GitMensch
GitMensch merged commit 7d61f09 into WebFreak001:master Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants