-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #415
Fixes #415
Conversation
read thread names, fix variable creation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
==========================================
- Coverage 20.55% 20.49% -0.06%
==========================================
Files 14 14
Lines 1800 1805 +5
Branches 388 390 +2
==========================================
Hits 370 370
- Misses 1385 1390 +5
Partials 45 45 ☔ View full report in Codecov by Sentry. |
src/mibase.ts
Outdated
}).catch(error => { | ||
}).catch((error: MIError) => { | ||
if (error.message === 'Selected thread is running.') { | ||
console.error(error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console
stuff is not logged on the client, it's just lost
you probably want to either use the DAP error response or send it to the output using this.handleMsg("stderr", "...")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the console
when debugging the extension. I wanted to ignore this message because it's not an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will have to either do sendResponse
or sendErrorResponse
here though, otherwise it's a hanging response that can cause issues with various DAP consumers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I used this.handleMsg
like you suggested.
There were linting problems, so I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you revert the package lock changes because of npm update --save
and only run do the typescript update? The other stuff should not change
I reverted the changes and then I just did |
Hello,
I tried ND on Windows with VSCode 1.87.1 and GDB 14.2 and ran into a lot of problems. I fixed some of them:
It still does not display global or member variables, maybe I will fix it later.