cleanInvalidSocketPath on start #400
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 20.89% 20.62% -0.27%
==========================================
Files 14 14
Lines 1771 1794 +23
Branches 381 387 +6
==========================================
Hits 370 370
- Misses 1356 1379 +23
Partials 45 45 ☔ View full report in Codecov by Sentry. |
|
@WebFreak001 Should I rebase and fix the linting issues - or isn't this likely to get merged? |
src/mibase.ts
Outdated
| if (files.length == 0) resolve(''); | ||
| files.forEach((file)=>{ | ||
| try { | ||
| const conn = net.connect(systemPath.join(socketlists, file)); |
There was a problem hiding this comment.
The only thing needed now (manually): testing that everything works fine with two separate debugging sessions.
To easily test that outside of a dev environment it would be nice if the CI could create a vsix artifact...
|
cleaning up at startup sounds like a reasonable idea to me |
GitMensch
force-pushed
the
cleanup-on-start
branch
2 times, most recently
from
8770e2c to
392ef6a
Compare
check for existing and invalid debugserver sockets on start and close those originally done by @chenhaoyang2019 as a side change in fd7d8ee1642b6e29e84667daefd4083c0771af45 at https://gitee.com/openkylin/native-debug.git
GitMensch
force-pushed
the
cleanup-on-start
branch
from
392ef6a to
8b1188c
Compare
|
Not sure what the lint-docs want, when I run prettier on that file, I get the exact same result. |
|
issues in CHANGELOG.md? |
|
looks like my version bump was missing a link when I updated the docs - will fix in master |
|
fixed on master now |
|
Please recheck the changes, if they look good to you now I'll rebase and merge. Thanks! |
|
@WebFreak001 updated and possibly ready to merge (still haven't done any tests other than the passing unit-tests, so inspecting those changes manually seems reasonable). As I just recognized how much we have in the Changelog already... a new release would be really good. |
start for existing and invalid debugserver sockets and close those
originally done by @chenhaoyang2019 as a side change in fd7d8ee1642b6e29e84667daefd4083c0771af45 at https://gitee.com/openkylin/native-debug.git
Note: this is not verified at all, I mostly wanted to point this change (and fork, which is published as Kylin Native Debug) out and let others review this in more depth.
The parts that are a bit more complex and relevant "upstream" are:
... and some unrelated changes like editor tab commands to start/stop recording via GDB (which sadly does not work well on most platforms, is very likely gdb-only, and can be enabled/disabled via debug console).