Added support for tilde to be present on the cwd through untildify #288
Conversation
|
I’ve tested this with tilde in the cwd. Previously I’d see ‘lldb-mi’ not found errors when running the child process spawn for the debugger due to the tilde in the cwd. With this fix I no longer see that errror |
|
untildify is MIT-licensed as other dependencies (most important the vscode parts) are, so I assume this is fine. Note: untildify currently only works for plain |
|
Looks like they don’t need that. At least it seemed to work on my machine but my setup is a bit weird. I’m running this through a dap adapter in emacs. I’ve verified the name in emacs is using a relative path for the executable under debug for lldb it seems to be fine. |
| @@ -97,7 +98,7 @@ class GDBDebugSession extends MI2DebugSession { | |||
| this.sendErrorResponse(response, 102, `Failed to SSH: ${err.toString()}`); | |||
| }); | |||
| } else { | |||
| this.miDebugger.load(args.cwd, args.target, args.arguments, args.terminal).then(() => { | |||
| this.miDebugger.load(untildify(args.cwd), args.target, args.arguments, args.terminal).then(() => { | |||
There was a problem hiding this comment.
should this really be done in gdb/lldb.ts instead of in the mi engine? You also changed the indentation on most lines by accident.
Additionally this should probably be done on target as well for consistency.
Closes #287