Release280 #705
Open
Release280 #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handle small details with RTL based sites. Touch up on whitespace * fix an indent misalignment * admin styles build
* remove extra S. Fixes CC-451 * touch up some new field styling to reduce vertical space * admin css build files * new field to toggle whether or not to show descriptions on frontend * add new admin only description value to our frontend returned values * conditionally show the description if it is meant to be shown on frontend * rename our field key and update the wording * rename our selectors and also add some flexbox usage for alignment purposes * asset builds
* upgrade our package to CMB2 2.11.0 * update defuse encryption
* new site health panel items for missed connections and a quick link to the constant contact status page * while we are here, make use of some return types from php7, fix typo, fill in parameter description * add in some reCAPTCHA status details * organization and alignment cleanup
* remove no longer used travis.yml * remove no longer used apigen.neon * update files that ignore or delete files we no longer have * touch up our readme.md file * we have a file in the folder, so this one is not needed
* begin server side render for when not selected. Adjust styling a little bit to remove admin-based styles. Clean up old css * early build versions * duplicate css but needed. borrow from our frontend css to add to our editor sass file for in-editor previewing. * update build files with latest changes
* rewrite forms file to be jQuery-less * Due to the fact that I can't find anything in the current codebase that refers to a "connection-settings-redirect" html class, I think this small part of the javascript is orphaned. On top of that, I checked out the 2.0.0 branch when it was first introduced, and still couldn't find any references to the class. Given the scope and size of the 2.0.0 release, I must conclude that the javascript spot was originally implemented at one time during the 2.0.0 release work, but a pivot was made and the js was missed for removal afterwards. I have tested the connection process without this snippet in the build files, and our workflow remained unaffected. If by chance we need to re-add in, after a release and support comes in, we most definitely can. * begin conversion to vanilla js for ajax plugin * early ajax conversion work * remove the passing in of jQuery * remove jquery dependency in clipboard file * handle possible many selected items * we no longer have a newsletter signup form in our newsletter plugin * merge in changes from what should be a 2.6.1 release * handle change events * begin builder file conversion * refactor "that.noUniqueWarning" function * initialie our function directly instead of through jQuery * fill in some documentation about functionality * remove beforeunload event listener * rework validateUniqueFieldLabels * rework duplicates removal * code cleanup/linting * handle proper add/remove for events * convert modifyFields function * commit all of our source changes for now to avoid stash loss * rename our request action * Feature/cc 426 new update notification (#674) * early versions of new notification for urging to update the plugin. * new notification setup regarding pending updates * revise notification content to include links to the update page * fix typo * early return for non-admins * remove unneeded comparisons * early return for non CTCT sections * make same chagnes from #682 into our branch and src file here * misc extra whitspace removal * reset this file from main, reapply as able slowly after * add an ID to our specific modal popup * revise our clear first form ajax handler to have better return values. * remove the majority of the jQuery from our modal file. Leaving some parts for sake of jQuery Dialog * provide some custom review action statuses * rework our fetch ajax usage to one that is presently working * compiled versions at this point in time * initially finish off completion of converting the bindevents function. some jQuery required to remain due to jQuery events * build files * revise our unload handling to be modern * some inital jslint cleanup * watch and build files * general code cleanup/alignment on our source files * post code cleanup compilation * Feature/cc 438 failed disconnect submission hardening (#684) * move our missed api request method to public. * remove is_connected check and target our list array index more directly * begin checking if we have a list, but are not connected at the moment, and attempt to save the record * construct a contact array to match existing code * new methods to help with email notifications about API issues. Making this more direct and not dependent on logging in to see * colaborated wordsmithing with Constant Contact * fill in version number * Fix/cc 440 comment login signup errors (#683) * filter out woocommerce specific lists from the forms plugin * this is not serving any purpose * return early if we do not have any lists * while we should have a list item for each, do an empty check before trying to add to array * wp core get_option only has 2 parameters available to it. * Fix/cc 444 optin ux updates (#682) * remove old comments * build files * hide optin if we have no lists available but are connected * build files * fill in current changelog items, fill in misse CHANGELOG.md items * plugin version bumps for release branch * one of my greatest const-quests in javascript, while letting some remain due to situations explained. * build files from new sources * remove duplicate code
…indicating already having an account (#706)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges in all previously reviewed features and fixes into our main branch.