Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recreated the slider using function called out for each butto #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,19 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="styles.css">
<script src="script.js" defer></script>
<script src="script2.js" defer></script>
<title>Document</title>
</head>
<body>
<section aria-label="Newest Photos">
<div class="carousel" data-carousel>
<button class="carousel-button prev" data-carousel-button="prev">&#8656;</button>
<button class="carousel-button next" data-carousel-button="next">&#8658;</button>
<button class="carousel-button prev" id="button-prev" data-carousel-button="prev">&#8656;</button>
<button class="carousel-button next" id="button-next" data-carousel-button="next">&#8658;</button>
<ul data-slides>
<li class="slide" data-active>
<img src="https://source.unsplash.com/78A265wPiO4" alt="Nature Image #1">
</li>
<li class="slide">
<li class="slide" id="active-slide">
<img src="https://source.unsplash.com/78A265wPiO4" alt="Nature Image #1">
</li >
<li class="slide" >
<img src="https://source.unsplash.com/eOpewngf68w" alt="Nature Image #2">
</li>
<li class="slide">
Expand Down
16 changes: 13 additions & 3 deletions script.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
const buttons = document.querySelectorAll("[data-carousel-button]")
const buttons = document.querySelectorAll("[data-carousel-button]") /* selects the buttons and store in buttons variable (now an array) */

buttons.forEach(button => {
button.addEventListener("click", () => {
buttons.forEach(button => { /* loops thru all buttons and adding an event listener that will perform a function */
button.addEventListener("click", () =>



{
const offset = button.dataset.carouselButton === "next" ? 1 : -1
const slides = button
.closest("[data-carousel]")
Expand All @@ -15,4 +19,10 @@ buttons.forEach(button => {
slides.children[newIndex].dataset.active = true
delete activeSlide.dataset.active
})



})

/* the function basically sets data-active into one of the slides by using offset variable as index (or new index) adding or subtracting depending
on which button is pressed which will set the data-attribute to the element with the new index */
43 changes: 43 additions & 0 deletions script2.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
let offset = 0;
let buttonPrev = document.getElementById("button-prev");
let buttonNext = document.getElementById("button-next");



buttonPrev.addEventListener("click", moveSlidePrev);
buttonNext.addEventListener("click", moveSlideNext);

function moveSlidePrev() {
offset = -1;
slideMovement();


}

function moveSlideNext() {
offset = 1;
slideMovement();


}


const slideMovement= () => {
let slides = document.querySelectorAll("li");
let activeSlide = document.getElementById("active-slide");
let newIndex = [...slides].indexOf(activeSlide) + offset

if (newIndex >= slides.length) {
newIndex = 0;
}

if (newIndex < 0) {
newIndex = slides.length - 1
};

console.log(newIndex);
activeSlide.removeAttribute("id","active-slide");
slides[newIndex].setAttribute("id","active-slide");


}
6 changes: 6 additions & 0 deletions styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ body {
transition-delay: 0ms;
}

#active-slide {
opacity: 1;
z-index: 1;
transition-delay: 0ms;
}

.carousel-button {
position: absolute;
z-index: 2;
Expand Down