wasi:[email protected]: Add tests for symbolic links #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingo
changed the title
wingo
force-pushed
the
filesystem-symbolic-links
branch
2 times, most recently
from
667abf4 to
b3e1496
Compare
wingo
changed the title
wingo
force-pushed
the
filesystem-symbolic-links
branch
from
b3e1496 to
8285239
Compare
|
Would it make sense to add this test case? WASIT found this sandbox escape in WAMR. In short, this tests that backslashes are properly handled in symlinks. |
pchickey
approved these changes
Sep 29, 2025
|
|
||
| assert_eq!(ln_s("whatever", "").await, Err(ErrorCode::NoEntry)); | ||
| assert_eq!(ln_s("", "whatever").await, Err(ErrorCode::NoEntry)); | ||
| // symlink-at: async func(old-path: string, new-path: string) -> result<_, error-code>; |
There was a problem hiding this comment.
Did this belong up at line 68?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.