fix: move incoming value ownership on consumption #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Volosatovs <[email protected]>
rvolosatovs
force-pushed
the
fix/incoming-value-ownership
branch
from
4170216 to
cb1663e
Compare
rvolosatovs
added a commit
to rvolosatovs/wasmCloud
that referenced
this pull request
Feb 12, 2024
WebAssembly/wasi-keyvalue#39 Signed-off-by: Roman Volosatovs <[email protected]>
rvolosatovs
added a commit
to rvolosatovs/wasmCloud
that referenced
this pull request
Feb 12, 2024
WebAssembly/wasi-keyvalue#39 Signed-off-by: Roman Volosatovs <[email protected]>
rvolosatovs
added a commit
to rvolosatovs/wasmCloud
that referenced
this pull request
Feb 13, 2024
WebAssembly/wasi-keyvalue#39 Signed-off-by: Roman Volosatovs <[email protected]>
rvolosatovs
added a commit
to wasmCloud/wasmCloud
that referenced
this pull request
Feb 13, 2024
WebAssembly/wasi-keyvalue#39 Signed-off-by: Roman Volosatovs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource methods implicitly borrow the resource, however, to "consume" the value, ownership of it must be moved.
In some way this is similar to https://github.com/WebAssembly/wasi-http/blob/37b91f4f78950f87db61e462ab6dacf85827bc64/wit/types.wit#L426