Add name annotations for all extended name things - #10
Open
bvisness wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just fleshing out the
@namepart of the proposal. The only interesting part is the claim about where name annotations can be used: always in places where binding identifiers are allowed, plus a few places where non-binding identifiers are allowed, but never where identifiers are not allowed.I think this claim is correct, and I think it should hold in the future. The non-binding bit is for things like
(module (@name "foo"))or (temporarily) for(type (func (param (@name "foo") i32))), but it is not correct to say that name annotations are allowed everywhere identifiers are allowed, because ofblock $x ... end $x.