[wasm-split] Don't use ParallelFunctionAnalysis in scanModule - #9007
Open
aheejin wants to merge 1 commit into
Open
[wasm-split] Don't use ParallelFunctionAnalysis in scanModule#9007aheejin wants to merge 1 commit into
aheejin wants to merge 1 commit into
Conversation
This removes the use of `ParallelFunctionAnalysis` within `scanModule` (in `computeUsedNames`), which scans `UsedNames` for each module. I'm not 100% sure why but this improves running time at least for Dart applications. I also previously tried to use `ParallelFunctionAnalysis` in other functions but it resulted in slowdown so didn't do it. Maybe cache locality works against the parallelism. This reduces running time of acx_gallery (Jul 2026) by 7.8% (30.6s -> 28.2s) essentials by 4.2% (225.1s -> 215.6s).
aheejin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the use of
ParallelFunctionAnalysiswithinscanModule(incomputeUsedNames), which scansUsedNamesfor each module.I'm not 100% sure why but this improves running time at least for Dart applications. I also previously tried to use
ParallelFunctionAnalysisin other functions but it resulted in slowdown so didn't do it. Maybe cache locality works against the parallelism.This reduces running time of acx_gallery (Jul 2026) by 7.8% (30.6s -> 28.2s) essentials by 4.2% (225.1s -> 215.6s).