JSON: Implement printing for all types#8701
Merged
Merged
Conversation
tlively
approved these changes
May 14, 2026
Comment on lines
+35
to
+36
| // TODO: Use wtf16.view() once we have C++20. | ||
| wasm::String::printEscapedJSON(os, wtf16.str()); |
Member
Author
There was a problem hiding this comment.
Done, before I just moved this around without reading...
Comment on lines
+49
to
+52
| if (pretty) { | ||
| os << '\n'; | ||
| doIndent(); | ||
| } |
Member
There was a problem hiding this comment.
Maybe it's worth pulling out this snippet into a newLine() helper?
| explicit Value(const char* s) : type(Null) { setString(s); } | ||
| explicit Value(const std::string& s) : type(Null) { setString(s.c_str()); } | ||
| explicit Value(const std::string_view& s) : type(Null) { | ||
| setString(std::string(s)); |
Member
There was a problem hiding this comment.
Suggested change
| setString(std::string(s)); | |
| setString(s.data()); |
This seems like it does the same thing a little more directly.
Member
Author
There was a problem hiding this comment.
Hmm, but the data is not null-terminated?
tlively
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add minor quality-of-life improvements like nicer constructors.
This will be enough to print out JSON easily for fuzzing.