[Strings] Make string a subtype of ext, not any #7373
+61
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Mar 14, 2025
Comment on lines
+449
to
+451
| // Bottom types already handled (including string as the switch value, | ||
| // which implies the other value is bottom, which again would have been | ||
| // handled). |
There was a problem hiding this comment.
I don't understand the addition to this comment. string isn't a bottom type, so why is it included in the bottom types already having been handled?
| @@ -949,8 +956,9 @@ std::optional<HeapType> HeapType::getSuperType() const { | |||
| case none: | |||
| case exn: | |||
| case noexn: | |||
| case string: | |||
There was a problem hiding this comment.
Yikes! This doesn't look like it was correct before, since it should have returned any. Do you know how this wasn't caught by tests?
Comment on lines
-491
to
-493
| (any.convert_extern | ||
| (extern.convert_any | ||
| (string.const "string") |
There was a problem hiding this comment.
It might still be useful to test any.convert_extern of a string.
Comment on lines
+239
to
+240
| (ref.null noextern) ;; The change from stringref to externref does not | ||
| ;; cause problems here, nothing needs to change. |
There was a problem hiding this comment.
Does this unlock any potential code simplifications in StringLowering.cpp?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringLowering converts strings to externs, which makes sense as we lower
stringrefs to imported JS strings. For the reverse transform it is convenient
to just have strings be subtypes of ext, see #7370 - that makes it simple to
switch stringref to externref and vice versa.