Stack switching: fix some optimization passes #7271
Conversation
vouillon
force-pushed
the
stack-switching-fixes
branch
from
c067464 to
19e57a7
Compare
Update the type of the blocks that are targets of the handlers of resume and resume_throw instructions.
We were incorrectly comparing a tag name with block types.
vouillon
force-pushed
the
stack-switching-fixes
branch
from
19e57a7 to
50d6418
Compare
| @@ -503,6 +504,14 @@ class TypeMapper : public GlobalTypeRewriter { | |||
| return getTempType(type); | |||
| } | |||
|
|
|||
| HeapType getNewHeapType(HeapType type) { | |||
There was a problem hiding this comment.
Let's reimplement getNewType using type.with(getNewHeapType(type.getHeapType()).
src/wasm/wasm-ir-builder.cpp
Outdated
| if (!params[nparams - 1].isContinuation()) { | ||
| return Err{"the last argument of the continuation argument should be " | ||
| "itself a continuation"}; | ||
| } |
There was a problem hiding this comment.
Can we leave this to the validator? It doesn't look like ChildTyper::visitStackSwitch depends on the last parameter correctly being a continuation.
There was a problem hiding this comment.
Thanks for your time!
I have just removed this for now since validation is not implemented.
|
Fuzzing on the main branch after this landed, I see Hopefully that information (note the |
|
Hmm, |
|
Not just mine, but all of them 😉 #7430 |
This continues #7041 by adapting the optimizations passes to work with the stack switching instructions.