-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Cancel CI jobs when new commits are added to a PR #7269
Conversation
This should really be the default shouldn't it?
a62ede6
to
ce5150b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though I thought this is the current behavior? It always seemed that way when I looked at it. But maybe I didn't look carefully enough.
I know its true for circle ci and emscripten.. have you noticed it being true here too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is already the current behavior. Maybe making it explicit will cause the jobs to be canceled faster, but that would be surprising.
If its already the default then maybe we shouldn't land this. I couldn't fine that default documented anywhere.. |
This is not the default behaviour for Github. See the documentation here https://docs.github.com/en/enterprise-cloud@latest/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs#example-using-concurrency-and-the-default-behavior |
Based on this experiment I don't see this as being the current behaviour: #7273. Here I pushed a new change to an existing PR and the jobs from the first commit continued to run. |
This should really be the default shouldn't it?