Make stringview reference type shorthands non-nullable #6578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This is inconsistent with all other shorthands, but it is the latest behavior in V8. Fix the text and binary shorthands in both parsers and writers.
tlively
force-pushed
the
stringviews-nonnullable
branch
from
86aed86
to
a778d59
Compare
|
If we decide to land #6579, we don't need to land this at all. |
kripken
approved these changes
May 13, 2024
|
Closing this since #6579 landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inconsistent with all other shorthands, but it is the latest behavior in
V8. Fix the text and binary shorthands in both parsers and writers.