[Fix Bug]Don't filter out Visualis-share URLs #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
普通分享页特殊处理，可以不需要登录（不影响授权分享页，授权分享依旧需要登录）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we share a dashboard of Visualis in the normal way(no login required, as defined by Visualis), anonymous users would not be able to visit this shared URL because this 'edp.davinci.core.inteceptor.CurrentUserMethodArgumentResolver' would filter this URL out, don't let it pass, and this dashboard can never be really shared this way.
That's not what was intended to be.
This BUG is fixed in this PR.
普通分享页特殊处理，可以不需要登录（不影响授权分享页，授权分享依旧需要登录）