Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an error when there is a package.json but no repo url #10

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from
Open

fix an error when there is a package.json but no repo url #10

wants to merge 1 commit into from

Conversation

fharper
Copy link

@fharper fharper commented Dec 11, 2018

No description provided.

@waldyrious
Copy link

I might be missing something, but how exactly does the new code behave differently than the current one?

@fharper
Copy link
Author

fharper commented Dec 12, 2018

The initial code is throwing a TypeError: Cannot read property 'url' of undefined if repo doesn't exist as it's accessing url. My small change is checking if repo exist before verifying if url also exists and use it if it's the case.

@waldyrious
Copy link

Ah, right, right. That's what I get for reading code late at night! 😅 Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants