Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window-manager: Ignore fullscreen requests for current state #2509

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

soreau
Copy link
Member

@soreau soreau commented Nov 6, 2024

This fixes dragging gtk4 apps with grid and/or wobbly disabled. The gtk4 toolkit sends a request for unfullscreen even though it is windowed, and this caused wayfire to set the geometry when dragging by titlebar, which made the window jump to an offset when grabbing the titlebar to move it.

Fixes #2507.

This fixes dragging gtk4 apps with grid and/or wobbly disabled. The gtk4
toolkit sends a request for unfullscreen even though it is windowed, and
this caused wayfire to set the geometry when dragging by titlebar, which
made the window jump to an offset when grabbing the titlebar to move it.

Fixes #2507.
@zougloub
Copy link

zougloub commented Nov 6, 2024

Tested here, OK.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@ammen99 ammen99 merged commit 2aeaf21 into master Nov 12, 2024
8 checks passed
@ammen99 ammen99 deleted the fix-2507 branch November 12, 2024 13:31
@mrsteve0924
Copy link
Contributor

i was seeing this issue with pavucontrol and this commit fixed the window jumpiness.

but now i get some weird behavior from the volume widget on wf-panel. the pop up volume slider appears then disappears with each mousescroll with each mouse scroll. then somehow fixes itself but then doesn't disappear unless i click off somewhere.

@ammen99
Copy link
Member

ammen99 commented Nov 15, 2024

but now i get some weird behavior from the volume widget on wf-panel. the pop up volume slider appears then disappears with each mousescroll with each mouse scroll. then somehow fixes itself but then doesn't disappear unless i click off somewhere.

This is a separate issue, please report it separately, not on unrelated PRs ;)

@mrsteve0924
Copy link
Contributor

mrsteve0924 commented Nov 15, 2024

well it looks like the culprit is #2479

ill submit it

EDIT: well after rebuilding to latest master again. it seems to be fixed. oh well.

arpio23 pushed a commit to droidian/wayfire that referenced this pull request Dec 20, 2024
…WM#2509)

This fixes dragging gtk4 apps with grid and/or wobbly disabled. The gtk4
toolkit sends a request for unfullscreen even though it is windowed, and
this caused wayfire to set the geometry when dragging by titlebar, which
made the window jump to an offset when grabbing the titlebar to move it.

Fixes WayfireWM#2507.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window move of gnome nautilus using mouse drag on title causes jump of window
4 participants