Port to wlroots 0.18.x #2452
Merged
Port to wlroots 0.18.x #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiled 0.9 with this PR - works ok so far. Seems like the new wlroots is better in terms of battery life at least for firefox-youtube. |
Thanks for testing! |
soreau
force-pushed
the
track-wlroots
branch
28 times, most recently
from
0e5e05e to
c9c1798
Compare
This leads to a crash on wlroots 0.18, as wlroots handles this already.
xdg wayland surfaces were not committing because compositors are expected to send a configure when wlr_xdg_surface.initial_commit is set.
There is nothing needed to do here when using wlr_output_state.
Without edge, latest only has 1.22 until possibly Nov '24, when alpine image 3.21 is released.
If a subsurface is created and then becomes smaller without repositioning, the old larger size was never damaged, leaving artifacts on the output.
This fixes the build.
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Nov 7, 2024
update to the latest git commit from the 'port to wlroots 0.18.x' upstream branch, cf WayfireWM/wayfire#2452
|
Since wlroots 0.18.2 has been released, I propose that we update to it before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gotchas:
wl_drm was dropped, so clients must update. A notable one is libva, which stopped working with wlroots 0.18 until upgrading libva.
wlr_input_inhibit was dropped and as of now, there is no replacement.
Possibilities:
linux-drm-syncobj-v1