Skip to content

Fix Rust 1.93 unsafe attribute and missing return value errors#9

Merged
Itsusinn merged 3 commits intomainfrom
copilot/fix-unsafe-attribute-error
Feb 5, 2026
Merged

Fix Rust 1.93 unsafe attribute and missing return value errors#9
Itsusinn merged 3 commits intomainfrom
copilot/fix-unsafe-attribute-error

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 5, 2026

Rust 1.93 requires unsafe attributes to be explicitly wrapped in unsafe(...). Additionally, the dump() method's jemallocator branch was missing a return value.

Changes

  • lib.rs line 7: Wrap export_name attribute in unsafe(...)

    - #[export_name = "malloc_conf"]
    + #[unsafe(export_name = "malloc_conf")]
  • controller.rs line 289: Add explicit Ok(()) return in jemallocator branch

    tokio::fs::write(&file_path, svg).await
        .wrap_err_with(|| format!("Failed to write flamegraph to {}", file_path))?;
    + 
    + Ok(())

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 5, 2026 09:45
Co-authored-by: Itsusinn <30529002+Itsusinn@users.noreply.github.com>
Co-authored-by: Itsusinn <30529002+Itsusinn@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix unsafe attribute usage in malloc_conf Fix Rust 1.93 unsafe attribute and missing return value errors Feb 5, 2026
Copilot AI requested a review from Itsusinn February 5, 2026 09:47
@Itsusinn Itsusinn marked this pull request as ready for review February 5, 2026 19:41
@Itsusinn Itsusinn merged commit fc03394 into main Feb 5, 2026
1 check passed
@Itsusinn Itsusinn deleted the copilot/fix-unsafe-attribute-error branch February 10, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants