feat(finance): add loading state to quick transfer #544
Conversation
- Updated `finance-quick-transfer.tsx` to include a `loading` prop and display `LoadingScreen` during loading state. - Adjusted `index.tsx` to pass the `loadingProfiles` state to the `FinanceQuickTransfer` component. This ensures better user feedback when profile data is being fetched.
- Removed unnecessary `console.log` statement from `finance-quick-transfer.tsx`. - Cleaned up the code to improve maintainability and reduce noise in the console.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #544 +/- ##
======================================
Coverage ? 8.40%
======================================
Files ? 558
Lines ? 30759
Branches ? 630
======================================
Hits ? 2585
Misses ? 27705
Partials ? 469 ☔ View full report in Codecov by Sentry. |
- Renamed `Props` to `FinanceQuickTransferProps` in `src/sections/finance/components/finance-quick-transfer.tsx`. - Updated component typing to use the new interface name. This change improves code readability and ensures clarity by using a more descriptive naming convention.
|
There was a problem hiding this comment.
@cswni is this PR ready? I am not sure what loader is this, could you upload an image or screen to understand better the context?
This is the screen, when contacts are loading show the animation loader. If profile has following, show the carousel; if not, an empty placeholder indicating to perform a search. |
This pull request introduces a loading state to the
FinanceQuickTransfercomponent and updates related components accordingly. The most important changes include adding a loading screen, updating thePropsinterface, and modifying theOverviewBankingViewcomponent to pass the loading state.Enhancements to
FinanceQuickTransfercomponent:src/sections/finance/components/finance-quick-transfer.tsx: ImportedLoadingScreencomponent to display a loading indicator.src/sections/finance/components/finance-quick-transfer.tsx: Updated thePropsinterface to include aloadingboolean.src/sections/finance/components/finance-quick-transfer.tsx: Modified the component to conditionally renderLoadingScreenbased on theloadingprop.Updates to
OverviewBankingViewcomponent:src/sections/finance/index.tsx: AddedloadingProfilesto theuseProfileFollowinghook to track the loading state of profile followings.src/sections/finance/index.tsx: Passed theloadingProfilesstate toFinanceQuickTransferto display the loading indicator when necessary. [1] [2]- Updatedfinance-quick-transfer.tsxto include aloadingprop and displayLoadingScreenduring loading state.index.tsxto pass theloadingProfilesstate to theFinanceQuickTransfercomponent. This ensures better user feedback when profile data is being fetched.