-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next #409
Merged
Merged
Next #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- **src/_mock/assets.ts** - Added extensive mock data including IDs, addresses, booleans, emails, names, roles, products, tours, job titles, company names, and other related fields for testing purposes. - Enhanced mock tags and descriptions to improve test coverage. - **src/sections/finance/components/banking-current-balance.tsx** - Introduced `BankingCurrentBalance` component to display current balance with carousel functionality. - Added helper components for balance display with toggleable visibility, edit, and delete options. - Used MUI, custom hooks, and utility functions for clean UI and interactions.
- `src/sections/finance/index.tsx`: Removed `_bankingContacts` import as it is no longer used. - `src/_mock/_overview.ts`: Deleted `_bankingContacts` definition to clean up unnecessary code. Simplifies the codebase and removes redundant data.
- Renamed `empty-notifications.png` from `public/assets/illustrations` to `src/assets/illustrations`. - Updated import path in `notifications-popover.tsx` to reflect the new location.
- Removed the `useSettingsContext` import and its usage from `src/sections/finance/index.tsx` due to redundancy. - Streamlined the code by cleaning up unused imports, enhancing readability and maintainability.
- Updated `useRouter` and `paths` imports to use absolute paths (`@src`). - Ensures consistent path referencing and improves code readability.
- `src/pages/dashboard/publication/play.tsx`: Changed `useParams` import to use an absolute path. - `src/sections/governance/view/governance-create-view.tsx`: Updated `useResponsive` and `useRouter` imports. - `src/sections/governance/view/governance-details-view.tsx`: Updated imports for `truncateAddress`, `useResponsive`, `paths`, and `useRouter`. - `src/sections/publication/view/publication-create-view.tsx`: Updated `useResponsive` import to an absolute path. - `src/components/subscribe-profile-modal.tsx`: Fixed incorrect semicolon usage in the error handling block.
- Introduced `should-login.tsx` to display a login prompt for unauthenticated users. - Implemented `withAuth.tsx` HOC to enforce authentication on protected components. - Added index file for easier exports of `ShouldLogin` component.
- Updated `src/layouts/dashboard/main.tsx`: - Added `position: 'relative'` to the main component's styles to ensure proper layout behavior. - This fixes potential issues with child component positioning.
- **src/sections/finance/index.tsx**: Updated widget titles from "Main Wallet" to "Main Balance" and "Pool Wallet" to "Pool Balance" for consistency. - **src/pages/dashboard/finance.tsx**: Wrapped `OverviewBankingView` with `withAuth` HOC to enforce authentication. These changes improve clarity in financial summaries and enhance security by requiring authentication for the finance page.
- Introduced `RainbowEffect` to enhance UI with animated styles, which dynamically switches between `NeonPaper` and `Box` based on loading state. - Updated button wrapper in modal to apply `RainbowEffect`, adding animation properties like `borderRadius` and `animationSpeed`. - Imported relevant components and removed unused imports for better code clarity.
- Updated `backgroundTaskMiddleware.ts` to include `pendingComment.metadata.content` in the task payload. - Enhances the middleware's ability to process comment-related tasks with more contextual metadata.
- **src/utils/subscribe-notifications-supabase.ts**: Added support for subscribing to multiple tables in notifications. - **src/layouts/_common/notifications-popover**: Enhanced popover with tabs for filtering notifications (all, unread, archived) and improved notification rendering. - **src/layouts/_common/notification-item.tsx**: Added actions for liking comments, replying, and deleting notifications, along with transaction/message rendering logic. - **src/sections/finance/components/banking-quick-transfer.tsx**: Implemented notification and transaction creation for fund transfers with supabase integration. - **src/hooks/use-notifications.ts**: Added a method to delete notifications from supabase and redux. - **src/redux/notifications/index.ts**: Integrated sound alert for new notifications and updated redux logic to support notification deletion. - **src/types/notification.ts**: Introduced a new notification category, "TRANSFER." - **src/routes/sections/index.tsx**: Configured notifications to subscribe to both "notifications" and "transactions" tables. - **src/components/activate-subscription-profile-modal.tsx**: Replaced circular progress with animated effect during subscription confirmation. - **src/assets/audio/notify.mp3**: Added notification sound file for audio alerts.
- Create a new redux slice under `src/redux/recent-transactions/index.ts`. - Define `TransactionItemProps` and `TransactionsState` types for transactions. - Add `setTransactions` and `appendTransaction` reducers for managing transactions.
- **banking-quick-transfer.tsx**: - Add `InputBase` from MUI for address input, replacing "Recent" label and "View All" button. This improves the user interface by enabling direct address input. - Refactor spread operator usage to include notification payload when sending a transfer. This optimizes the data sent in the API call and ensures completeness.
…finance # Conflicts: # src/sections/finance/components/banking-quick-transfer.tsx
- Added a new IconButton wrapped in a Tooltip for transferring between wallets in `src/sections/finance/index.tsx`. - Adjusted spacing in the summary widgets Stack from 3 to 1 for better alignment.
- Introduced `FinanceTransferAccounts` component for wallet transfers in `finance/index.tsx`. - Added `FinanceWalletTransferWidgetHorizontal` for horizontal wallet balance display. - Implemented `ConfirmTransferDialog` for wallet transfer confirmation, including input swap, slider, and amount validation functionality. - Removed old tooltip-based wallet transfer logic and replaced with new components for better UX.
- Removed unused imports from `banking-widget-summary.tsx` including framer-motion, IconButton, and color-related constants. - These imports were not utilized in the component and their removal helps streamline the code and reduces unnecessary dependencies.
- Renamed `banking-current-balance.tsx` to `finance-current-balance.tsx` and updated its export. - Renamed and updated all other component files under `src/sections/finance/components`: - `banking-balance-statistics.tsx` -> `finance-balance-statistics.tsx` - `banking-contacts.tsx` -> `finance-contacts.tsx` - `banking-recent-transitions.tsx` -> `finance-recent-transitions.tsx` - `banking-widget-summary.tsx` -> `finance-widget-summary.tsx` - `banking-invite-friends.tsx` -> `finance-invite-friends.tsx` - `banking-quick-transfer.tsx` -> `finance-quick-transfer.tsx` - Updated imports and references in `src/sections/finance/index.tsx` accordingly.
- `should-login.tsx`: Updated `notLoggedIn` component to accept `icon` and `subtitle` as props, added an icon display using `Iconify`, and adjusted styling/layout elements. - `withAuth.tsx`: Modified to pass `icon` and `subtitle` props to `ShouldLogin` for a more customized unauthorized view. - `finance.tsx`: Updated `withAuth` implementation to include new `icon` and `subtitle` parameters for the login prompt. This improves the user experience with a clearer and more visually appealing login prompt.
- Updated `finance-quick-transfer.tsx` to increase carousel scale transformation from 1.25 to 1.50 for highlighted items. - This change improves visual emphasis and user interaction clarity.
- **src/sections/finance/index.tsx**: Integrated `useTransactionData` and updated FinanceWidgetSummary and Balance Statistics components to use dynamic transaction data for balance and chart updates. Adjusted icons and percentage calculations based on transaction trends. - **src/utils/finance-graphs/groupedTransactions.ts**: Added utilities for grouping and processing transaction data by day, week, month, and year. Introduced logic to calculate daily financial metrics. - **src/hooks/use-transaction-data.ts**: Created a new hook to fetch, group, and expose transaction data for the authenticated user using Supabase.
- **finance-balance-statistics.tsx:** - Added `useEffect` to dynamically set `categories` from selected series. - Updated default `seriesData` to "Week" and added handling for series categories. - **finance-widget-summary.tsx:** - Removed unused Redux `useSelector` and session-related code. - Adjusted y-axis range by setting `min` to 0 and calculated dynamic `max`. - Fixed incorrect data type for `series.x` from `number` to `string`.
- Simplified `daySeriesData` processing in `index.tsx` by removing unnecessary mapping logic. - Removed unused `Button` component from `finance-recent-transitions.tsx` for a cleaner UI. - Adjusted carousel transition in `finance-quick-transfer.tsx` to include a blur effect for enhanced visuals. - Eliminated unused imports and parameters in `finance-transfer-accounts.tsx` to reduce clutter.
This component is no longer in use and has been fully removed. Key changes include: - Deleted `src/sections/finance/components/finance-change-wallet.tsx`. The removal helps in cleaning up obsolete code and improving maintainability.
- Updated `src/clients/viem/walletClient.ts` to remove the use of `infuraAPIKey` from the MetaMaskSDK configuration. - This change simplifies the wallet client setup by eliminating unnecessary dependency on `GLOBAL_CONSTANTS`. - Ensures a cleaner and more maintainable code structure for wallet integration.
- **finance-withdraw.tsx**: Removed `autoFocus` prop from the "Amount to withdraw" `TextField`. - **finance-deposit.tsx**: - Removed unused `enqueueSnackbar` import. - Removed `enqueueSnackbar` call for error logging. - Removed `autoFocus` prop from the "Amount to deposit" `TextField`. These changes simplify the components by removing redundant props and unused imports, improving code clarity and maintainability.
- src/hooks/use-deposit.ts: Added detailed error logs using `console.error`. - src/hooks/use-transfer.ts, src/hooks/use-authorize-policy.ts: Introduced `console.log` for easier error debugging. - src/hooks/use-deposit-metamask.ts: Replaced `enqueueSnackbar` with `console.log` for error messages, removing extra dependency. - src/utils/metamask.ts: Removed unused `GLOBAL_CONSTANTS`, refined MetaMask redirection logic, and ensured better compatibility across platforms.
- **finance-withdraw.tsx**: - Updated `amount` state to accept `number | string` to fix type mismatch issues. - Ensured `amount` is converted to `Number` before validations, operations, and API calls. - Adjusted `amount` value used in the display to handle proper type casting. - **finance-deposit.tsx**: - Similar changes as withdraw: updated `amount` state to `number | string`. - Converted `amount` to `Number` for validations, operations, and API calls. - Refactored type handling for better consistency across inputs.
…unt' into app/refactor/quick-trasnsfer-amount
- Introduced `FinanceMetamaskHelper` to guide users without MetaMask. - Updated `finance-withdraw-from-metamask.tsx` to render helper alongside the button. - Updated `finance-deposit-from-metamask.tsx` similarly to include the helper. - Adjusted margin styling in `FinanceMetamaskButton` for consistency.
…amount refactor: metamask handling
…amount feat: adapt new protocol contracts
- Updated `handleCarouselClick` in `finance-quick-transfer.tsx` to use `setCurrentIndex` instead of `carousel.setCurrentIndex`. - This ensures the selected profile updates the carousel index correctly upon user interaction.
…unt' into app/refactor/quick-trasnsfer-amount
…amount refactor: use setCurrentIndex instead of carousel.setCurrentIndex
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.