-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add faq page and style guide #193
Conversation
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Summary: The overall summary for the GitHub Pull Request titled "Add faq page and style guide" is as follows: Potential Issues and Errors:
Key Findings:
Additional Recommendations:
Overall, the patch brings several additions and updates related to the FAQ page, style guide, and troubleshooting guide. Some potential issues and errors should be addressed and reviewed. DetailsCommit 6a5c4a884bae8bb4e4587aca8bbe3bdb44d1e2c3Key Changes:
Potential Problems:
Commit 3c88c86ea0199f86f7f5b75aea6c451a3162ddd7Key changes in the patch:
Potential problems:
Commit 5a3c420de069c22d85d831f574d709bd9e21628cKey changes:
Potential problems:
Additional considerations:
Commit a7f3f7bcf4e982f98abc36a7e48c7a4a20c945dbKey Changes:
Potential Problems:
Overall, this patch adds a "Troubleshooting Guide" page and updates the file structure accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
@mhmohona I guess this PR is very different from #197. The #197 PR adds testing docs while this PR adds the FAQs. IMHO, it would be good to have the faq page CC @alabulei1 Could you please review it once again, as I personally feel, having a faq page for the project would be good |
Hey @adithyaakrishna, thanks for your review! |
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Hi @mhmohona could you please remove your faq page the style guide to https://wasmedge.org/docs/start/overview. We have a separate chapter for getting started. Thanks! |
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
* add faq page Signed-off-by: Mahfuza Humayra Mohona <[email protected]> * added style guide and updated faq Signed-off-by: Mahfuza Humayra Mohona <[email protected]> * moved files Signed-off-by: Mahfuza Humayra Mohona <[email protected]> * moving troubleshooting guide Signed-off-by: Mahfuza Humayra Mohona <[email protected]> --------- Signed-off-by: Mahfuza Humayra Mohona <[email protected]> Signed-off-by: kelvin <[email protected]>
Explanation
Added faq page for Wasmedge
Related issue
#37
Continuation of PR #198
What type of PR is this
/kind documentation
Proposed Changes