Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faq page and style guide #193

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Add faq page and style guide #193

merged 5 commits into from
Jan 19, 2024

Conversation

mhmohona
Copy link
Contributor

@mhmohona mhmohona commented Nov 9, 2023

Explanation

Added faq page for Wasmedge

Related issue

#37
Continuation of PR #198

What type of PR is this

/kind documentation

Proposed Changes

Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Copy link
Collaborator

alabulei1 commented Nov 9, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Summary:

The overall summary for the GitHub Pull Request titled "Add faq page and style guide" is as follows:

Potential Issues and Errors:

  • The patch introduces a new file STYLE_GUIDE.md, but it does not specify how this style guide will be used or enforced. Instructions on following the style guide should be provided.
  • The updates to the faq.md file do not seem to address any major issues or significantly improve the existing content. Discussions with the author about the necessity of these changes and potential improvements should be considered.
  • The links to the WasmEdge documentation and community resources in the faq.md file should be checked for accuracy and currency.
  • The moved and renamed files could potentially break existing references or URLs, and therefore they should be reviewed and updated if needed.
  • It is important to ensure that the moved and renamed files are correctly reflected in the overall project structure and navigation.

Key Findings:

  • The patch adds a FAQ page in both English and Chinese.
  • It introduces a style guide for both documentation and coding.
  • A troubleshooting guide is added and the appropriate files are moved and renamed.
  • No potential problems were identified in the patch.

Additional Recommendations:

  • Review the changes based on the project's coding and documentation style guidelines to ensure consistency.
  • Verify that any added or changed links or references are correctly pointing to the intended destinations.

Overall, the patch brings several additions and updates related to the FAQ page, style guide, and troubleshooting guide. Some potential issues and errors should be addressed and reviewed.

Details

Commit 6a5c4a884bae8bb4e4587aca8bbe3bdb44d1e2c3

Key Changes:

  • Added a new FAQ page in the docs/develop/getting-started/faq.md file.
  • Added a Chinese version of the FAQ page in the i18n/zh/docusaurus-plugin-content-docs/current/develop/getting-started/faq.md file.

Potential Problems:

  • No potential problems found in the patch.

Commit 3c88c86ea0199f86f7f5b75aea6c451a3162ddd7

Key changes in the patch:

  1. Added a new file STYLE_GUIDE.md that provides a style guide for both documentation and coding.
  2. Updated the faq.md file by making minor changes to the content and adding new links to the WasmEdge documentation and community resources.

Potential problems:

  1. The patch introduces a new file STYLE_GUIDE.md, but it does not specify how this style guide will be used or enforced. It would be beneficial to provide instructions on how contributors should follow this style guide.
  2. The updates to the faq.md file do not seem to address any major issues or improve the existing content significantly. It might be worth discussing with the author if these changes are necessary or if there are other potential improvements.
  3. The links to the WasmEdge documentation and community resources in the faq.md file should be checked to ensure they are correct and up-to-date.

Commit 5a3c420de069c22d85d831f574d709bd9e21628c

Key changes:

  • Moved the FAQ page from the "docs/develop/getting-started" directory to the "docs/start" directory.
  • Renamed the "STYLE_GUIDE.md" file to "docs/start/style_guide.md".
  • Created a new FAQ page in the "i18n/zh/docusaurus-plugin-content-docs/current/start" directory.
  • Added links to the FAQ page and Style Guide in the "docs/start/overview.md" file.

Potential problems:

  • The patch does not include any code changes, only file movements and renames. Therefore, it is difficult to identify potential problems without further context.
  • It is possible that the moved files and renamed files could break any existing references or URLs that were pointing to the old file locations. This should be carefully reviewed and updated if necessary.
  • It is also important to ensure that the moved files and renamed files are properly reflected in the overall project structure and navigation.

Additional considerations:

  • It is recommended to review the changes based on the project's coding and documentation style guidelines to ensure consistency.
  • If any links or references were added or changed in the patch, it is important to verify that they are correctly pointing to the intended destinations.

Commit a7f3f7bcf4e982f98abc36a7e48c7a4a20c945db

Key Changes:

  • Added a "Troubleshooting Guide" page to the "start" directory.
  • Renamed the "troubleshooting_guide.md" file in the "docs/develop/getting-started" directory to "docs/start/troubleshooting_guide.md".
  • Renamed the "troubleshooting_guide.md" file in the "i18n/zh/docusaurus-plugin-content-docs/current/develop/getting-started" directory to "i18n/zh/docusaurus-plugin-content-docs/current/start/troubleshooting_guide.md".

Potential Problems:

  • No potential problems were identified in this patch.

Overall, this patch adds a "Troubleshooting Guide" page and updates the file structure accordingly.

Copy link
Contributor

@adithyaakrishna adithyaakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@alabulei1
Copy link
Collaborator

Hi @mhmohona

It seems that #197 includes this PR. Should I merge this PR?

@mhmohona mhmohona closed this Dec 18, 2023
@adithyaakrishna
Copy link
Contributor

@mhmohona I guess this PR is very different from #197. The #197 PR adds testing docs while this PR adds the FAQs. IMHO, it would be good to have the faq page

CC @alabulei1 Could you please review it once again, as I personally feel, having a faq page for the project would be good

@mhmohona
Copy link
Contributor Author

Hey @adithyaakrishna, thanks for your review!
In above comment @alabulei1 meant #198 actually.

@mhmohona mhmohona reopened this Jan 6, 2024
Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
@mhmohona mhmohona changed the title Add faq page Add faq page and style guide Jan 6, 2024
@alabulei1
Copy link
Collaborator

Hi @mhmohona

could you please remove your faq page the style guide to https://wasmedge.org/docs/start/overview. We have a separate chapter for getting started. Thanks!

@alabulei1 alabulei1 merged commit 3d89ec8 into WasmEdge:main Jan 19, 2024
6 checks passed
kelvinparmar pushed a commit to kelvinparmar/docs that referenced this pull request Feb 3, 2024
* add faq page

Signed-off-by: Mahfuza Humayra Mohona <[email protected]>

* added style guide and updated faq

Signed-off-by: Mahfuza Humayra Mohona <[email protected]>

* moved files

Signed-off-by: Mahfuza Humayra Mohona <[email protected]>

* moving troubleshooting guide

Signed-off-by: Mahfuza Humayra Mohona <[email protected]>

---------

Signed-off-by: Mahfuza Humayra Mohona <[email protected]>
Signed-off-by: kelvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants